Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tpromise callback sig for TS 2.4 #30228

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Fix tpromise callback sig for TS 2.4 #30228

merged 1 commit into from
Jul 7, 2017

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jul 7, 2017

Fixes #30216

Changes the TPromise callback interface as suggested by #30216 (comment) to fix async functions that return a TPromise

@mjbvz
Fix tpromise callback sig for ts 2.4
ce724cf 
Fixes microsoft#30216

Changes the TPromise callback interface as suggested by microsoft#30216 (comment) to fix async functions when compiling using ts 2.4+
@mjbvz mjbvz added this to the July 2017 milestone Jul 7, 2017
@mjbvz mjbvz self-assigned this Jul 7, 2017
@mjbvz mjbvz requested review from bpasero, jrieken and alexdima July 7, 2017 07:03
@bpasero bpasero removed their request for review July 7, 2017 07:53
@mjbvz mjbvz merged commit 56d032e into microsoft:master Jul 7, 2017
@Martin-Luft Martin-Luft mentioned this pull request Jul 31, 2017
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken Awaiting requested review from jrieken

@alexdima alexdima Awaiting requested review from alexdima

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
July 2017
Development

Successfully merging this pull request may close these issues.

Fix TS 2.4 PromiseLike Errors With Async in VSCode Codebase
2 participants
@mjbvz @msftclas